Use MaybeUninit#72
Closed
pitdicker wants to merge 5 commits intomatklad:masterfrom
pitdicker:maybe_uninit
Closed
Conversation
Contributor
Author
|
It probably works better to swap the types to |
Contributor
Author
|
Late night ideas don't always work 😄.
The mention of |
This was referenced Nov 3, 2019
7 tasks
4 tasks
Owner
|
Turns out we can't use MaybeUninit -- we'll need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
UnsafeCell<Option<T>>withUnsafeCell<MaybeUninit<T>>.I included a terrible imitation of
MaybeUninitbased onOption, so there is no change in behavior right now. The real implementation that usesstd::mem::MaybeUninitis behind a feature flagmaybe_uninitand only usable with nightly.I did find one complexity:
OnceCellnow has to implementDropitself. Therefore it has to checkis_initialized.into_innernow has to use themem::replacetrick to move thevaluefield out of theOnceCell, and then free the cell without dropping (becauseinitializedis not reset).Conclusion: a bit messy. But I think it makes sense, as a preparation for the future. And it is a plus that
is_initializedis now the single source of truth.